GitHub Issue 950: cross folder export/import roundtripping problems for MVTC with commas and quotes#7523
Conversation
…or MVTC with commas and quotes
cnathe
requested changes
Mar 26, 2026
Comment on lines
+3245
to
+3246
| String displayVal = PageFlowUtil.joinValuesToStringForExport(array); | ||
| return _tsvWriter.quoteValue(displayVal.trim()); |
Contributor
There was a problem hiding this comment.
it looks like MultiChoice.Array has a toString() method that does the PageFlowUtil.joinValuesToStringForExport part. Could this be changed to use that?
i.e. return _tsvWriter.quoteValue(array.toString().trim());
cnathe
approved these changes
Mar 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
Cross folder/type import writes data file into partitions. When writing MVTC fields, we need to make sure the array is converted to exportable string and escaped properly.
Related Pull Requests
Changes